szehon-ho commented on code in PR #52669:
URL: https://github.com/apache/spark/pull/52669#discussion_r2457980883
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala:
##########
@@ -2154,6 +2161,41 @@ abstract class MergeIntoTableSuiteBase extends
RowLevelOperationSuiteBase
}
}
+ test("Merge metrics with numSourceRows for empty source") {
Review Comment:
Is this one because Optimizer get rid of the join due to it not returning
any result (no matching pks between source and target)? Let's tackle it in a
follow up
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala:
##########
@@ -2098,6 +2103,7 @@ abstract class MergeIntoTableSuiteBase extends
RowLevelOperationSuiteBase
val table = catalog.loadTable(ident)
val commitProps =
table.asInstanceOf[InMemoryTable].commits.last.properties
+ assert(commitProps("merge.numSourceRows") === "4")
Review Comment:
let's run these tests in AQE/non-AQE mode to verify the walk works in both
scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
