szehon-ho commented on code in PR #52599:
URL: https://github.com/apache/spark/pull/52599#discussion_r2458046767
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTable.scala:
##########
@@ -125,6 +125,41 @@ class InMemoryTable(
new InMemoryWriterBuilderWithOverWrite(info)
}
+ override def copy(): Table = {
+ val copiedTable = new InMemoryTable(
+ name,
+ columns(),
+ partitioning,
+ properties,
+ constraints,
+ distribution,
+ ordering,
+ numPartitions,
+ advisoryPartitionSize,
+ isDistributionStrictlyRequired,
+ numRowsPerSplit)
+
+ copiedTable.dataMap.synchronized {
Review Comment:
nit: does this help? We dont return copiedTable yet so there's no chance
this code conflicts with another access of copiedTable's dataMap?
Also curious if we can just use super.copy() and set fields instead of
constructing InMemoryTable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
