cloud-fan commented on code in PR #52712:
URL: https://github.com/apache/spark/pull/52712#discussion_r2458668580
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -224,7 +225,7 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
nameInCache.length == name.length &&
nameInCache.zip(name).forall(conf.resolver.tupled)
}
- plan match {
+ EliminateSubqueryAliases(plan) match {
Review Comment:
yea we don't need `SubqueryAlias` in the cache keys, as during lookup, we
call `LogicalPlan#sameResult` which strips the `SubqueryAlias`.
However, the cache key logical plans are exposed to custom normalization
rules (See SparkSessionExtensions#injectPlanNormalizationRule), so seems safer
to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
