jerrypeng commented on code in PR #52620: URL: https://github.com/apache/spark/pull/52620#discussion_r2462187188
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/runtime/StreamingQueryPlanTraverseHelper.scala: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.streaming.runtime + +import org.apache.spark.sql.execution.SparkPlan +import org.apache.spark.sql.execution.columnar.InMemoryTableScanExec + +/** + * This is a utility object placing methods to traverse the query plan for streaming query. + * This is used for patterns of traversal which are repeated in multiple places. + */ +object StreamingQueryPlanTraverseHelper { + def collectFromUnfoldedLatestExecutedPlan[B]( + lastExecution: IncrementalExecution)(pf: PartialFunction[SparkPlan, B]): Seq[B] = { + val executedPlan = lastExecution.executedPlan + + collectWithUnfolding(executedPlan)(pf) + } + + private def collectWithUnfolding[B](executedPlan: SparkPlan)( + pf: PartialFunction[SparkPlan, B]): Seq[B] = { + executedPlan.flatMap { + // InMemoryTableScanExec is a node to represent a cached plan. The node has underlying + // actual executed plan, which we should traverse to collect the required information. + case s: InMemoryTableScanExec => collectWithUnfolding(s.relation.cachedPlan)(pf) Review Comment: After some additional thinking, these conditions this code checks is not relevant to RTM. I will just remove this code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
