ganeshashree commented on PR #52402: URL: https://github.com/apache/spark/pull/52402#issuecomment-3451033736
> @cloud-fan which old method do you mean? The constructor has changed and that's breaking for Java code. @manuzhang Thanks for reporting this. The current changes are backward compatible with Scala but not with Java. I see that [two tests in Iceberg 4.0](https://github.com/search?q=repo%3Aapache%2Ficeberg+return+new+MemoryStream+path%3A%2F%5Espark%5C%2Fv4%5C.0%5C%2Fspark%5C%2Fsrc%5C%2Ftest%5C%2Fjava%5C%2Forg%5C%2Fapache%5C%2Ficeberg%5C%2Fspark%5C%2Fsource%5C%2F%2F&type=code) are breaking due to this change. Is it fine to modify the tests to use SparkSession instead of sqlContext? Please let me know if you rely on the old version of the constructor that takes sqlContext as a parameter. I can consider making this change backward compatible with Java as well. However, since sqlContext is deprecated, it is best practice to use the new version of the constructor and pass sparkSession as a parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
