ueshin commented on code in PR #52755: URL: https://github.com/apache/spark/pull/52755#discussion_r2468006884
########## core/src/main/scala/org/apache/spark/api/python/PythonSparkThrowable.scala: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.api.python + +import java.util + +import org.apache.spark.{BreakingChangeInfo, QueryContext, SparkThrowable} + +/** + * A wrapper class for [[SparkThrowable]] used in the Python side. + * + * This class delegates all method calls to the underlying [[SparkThrowable]] instance. + * It exists to make [[SparkThrowable]] accessible from PySpark through Py4J, since + * Python cannot directly work with default methods. + * + * NOTE: If new default methods are added to [[SparkThrowable]], they must also be + * explicitly delegated here to maintain consistent behavior. A unit test should verify + * that all default methods are properly delegated. + */ +private[spark] class PythonSparkThrowable(e: SparkThrowable) extends SparkThrowable { Review Comment: How about just taking `Exception` or `Throwable` and check if it's `SparkThrowable` or not in each method, returning values from the `SparkThrowable` or the default values if it's not. Then we don't need to care about the actual exception in Python side, and communication with JVM thorough Py4J that should have an overhead will be reduced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
