hvanhovell commented on code in PR #52496: URL: https://github.com/apache/spark/pull/52496#discussion_r2473093481
########## sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala: ########## @@ -82,6 +86,7 @@ private[sql] class SparkResult[T]( private[this] var arrowSchema: pojo.Schema = _ private[this] var nextResultIndex: Int = 0 private val resultMap = mutable.Map.empty[Int, (Long, Seq[ArrowMessage])] + private val arrowBatchChunksToAssemble = mutable.Buffer.empty[ByteString] Review Comment: Should this be local to processReponses? AFAICT it should not return unless we have a complete arrow batch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
