miland-db commented on code in PR #52762:
URL: https://github.com/apache/spark/pull/52762#discussion_r2473525929
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala:
##########
@@ -90,7 +90,19 @@ trait TimestampFormatterHelper extends
TimeZoneAwareExpression {
@transient final protected lazy val formatterOption:
Option[TimestampFormatter] =
if (formatString.foldable) {
- Option(formatString.eval()).map(fmt => getFormatter(fmt.toString))
+ Option(formatString.eval()).map { fmt =>
+ try {
Review Comment:
Oh.. The idea was to remove try catch here, I forgot to remove it. As you
said, it is not needed anymore in this place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
