szehon-ho commented on code in PR #52347:
URL: https://github.com/apache/spark/pull/52347#discussion_r2475978932
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala:
##########
@@ -38,6 +39,17 @@ import org.apache.spark.sql.types.{ArrayType, DataType,
DecimalType, IntegralTyp
object TableOutputResolver extends SQLConfHelper with Logging {
+ object DefaultValueFillMode extends Enumeration {
+ val FILL, RECURSE, NONE = Value
+
+ def getChildMode(mode: DefaultValueFillMode.Value):
DefaultValueFillMode.Value = {
Review Comment:
Ah, need a flag whether to recrurse. See :
https://github.com/apache/spark/pull/52347#discussion_r2471112688
Its a bit hard to do as the method reorderColumnsByName doesnt recurse
directly into itself , but indirectly via resolveStruct/Map/ArrayType
I removed this method in latest patch, hopefully its cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
