Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6652#discussion_r31975382
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
    @@ -800,6 +800,50 @@ class DAGSchedulerSuite
         assertDataStructuresEmpty()
       }
     
    +  test("shuffle with reducer locality") {
    --- End diff --
    
    ok last supernit: can you make this name a description of what should 
happen? "Reduce tasks should be placed locally with map output" and then for 
the below test "Reduce task locality preferences should only include machine 
with largest map output" or something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to