pan3793 commented on code in PR #52757:
URL: https://github.com/apache/spark/pull/52757#discussion_r2476283149
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala:
##########
@@ -76,8 +77,11 @@ class SparkConnectDatabaseMetaData(conn:
SparkConnectConnection) extends Databas
override def getIdentifierQuoteString: String = "`"
- override def getSQLKeywords: String =
- throw new SQLFeatureNotSupportedException
+ override def getSQLKeywords: String = {
+ conn.checkOpen()
+ conn.spark.sql("SELECT keyword FROM sql_keywords()").collect()
Review Comment:
I can imagine one possible case, if we upgrade the connect server, and
because connect jvm client supports retry, they can get the new keywords list
if server makes such changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
