cloud-fan commented on code in PR #52730:
URL: https://github.com/apache/spark/pull/52730#discussion_r2477603606
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -598,7 +598,17 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
if (tableDefinition.tableType == VIEW) {
val newTableProps = tableDefinition.properties ++
tableMetaToTableProps(tableDefinition).toMap
- val newTable = tableDefinition.copy(properties = newTableProps)
+ val schemaWithNoCollation = removeCollation(tableDefinition.schema)
+ val hiveCompatibleSchema = schemaWithNoCollation match {
+ // Spark-created views do not have to be Hive compatible. If the data
type is not
+ // Hive compatible, we can set schema to empty so that Spark can still
read this
+ // view as the schema is also encoded in the table properties.
+ case schema if tableDefinition.tableType == CatalogTableType.VIEW &&
Review Comment:
```suggestion
case schema if
```
we are already inside `if (tableDefinition.tableType == VIEW)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
