yhuang-db commented on code in PR #52529:
URL: https://github.com/apache/spark/pull/52529#discussion_r2479442860
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2Suite.scala:
##########
@@ -1081,6 +1167,18 @@ class SimpleDataSourceV2 extends TestingV2Source {
override def planInputPartitions(): Array[InputPartition] = {
Array(RangeInputPartition(0, 5), RangeInputPartition(5, 10))
}
+
Review Comment:
`equals` needs to be implemented by scan itself.
Connector would have it own scan implementation, hence
DataSourceV2ScanRelation cannot canonicalize the scan object by itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
