cloud-fan commented on code in PR #52806:
URL: https://github.com/apache/spark/pull/52806#discussion_r2480350083


##########
sql/core/src/test/resources/sql-tests/analyzer-results/nonansi/st-functions.sql.out:
##########
@@ -22,6 +22,342 @@ InsertIntoHadoopFsRelationCommand file:[not included in 
comparison]/{warehouse_d
    +- LocalRelation [col1#x]
 
 
+-- !query
+SELECT CAST(ST_GeogFromWKB(X'0101000000000000000000f03f0000000000000040') AS 
BOOLEAN) AS result

Review Comment:
   this is end to end test, we don't need to test all cases which should be 
done by unit tests.
   
   I think we only need 3 test cases: geo to non-geo (let's pick int), non-geo 
to geo, geo to geo.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to