pan3793 commented on code in PR #52810:
URL: https://github.com/apache/spark/pull/52810#discussion_r2480350285
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectStatement.scala:
##########
@@ -123,8 +143,15 @@ class SparkConnectStatement(conn: SparkConnectConnection)
extends Statement {
override def setCursorName(name: String): Unit =
throw new SQLFeatureNotSupportedException
- override def getUpdateCount: Int =
- throw new SQLFeatureNotSupportedException
+ override def getUpdateCount: Int = {
+ checkOpen()
+
+ if (resultSet != null) {
+ -1
+ } else {
+ 0 // always return 0 because affected rows is not supported yet
Review Comment:
this can not be supported soon because it requires non-trivial work on the
classic sql module to add metrics for all data writing commands and modify the
connect protocol to retrieve them back to the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
