cloud-fan commented on code in PR #52759:
URL: https://github.com/apache/spark/pull/52759#discussion_r2491704033
##########
sql/catalyst/src/test/java/org/apache/spark/sql/connector/catalog/CatalogLoadingSuite.java:
##########
@@ -66,11 +69,13 @@ public void testInitializationOptions() throws
SparkException {
TestCatalogPlugin testPlugin = (TestCatalogPlugin) plugin;
- Assertions.assertEquals(2, testPlugin.options.size(), "Options should
contain only two keys");
+ Assertions.assertEquals(3, testPlugin.options.size(), "Options should
contain only three keys");
Assertions.assertEquals("not-catalog-name", testPlugin.options.get("name"),
"Options should contain correct value for name (not overwritten)");
Assertions.assertEquals("valUE", testPlugin.options.get("key"),
"Options should contain correct value for key");
+ Assertions.assertEquals(JavaUtils.osName, testPlugin.options.get("osName"),
+ "Options should contain correct substitution for value");
Review Comment:
```suggestion
"Options should contain correct substitution for value");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
