cloud-fan commented on code in PR #46143:
URL: https://github.com/apache/spark/pull/46143#discussion_r2491790363
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala:
##########
@@ -404,6 +404,16 @@ abstract class Expression extends TreeNode[Expression] {
} else {
""
}
+
+ /**
+ * A _very rough_ indication of the expected cost of evaluating an
expression.
+ * This can be used by the optimizer to decide if an element should be double
+ * evaluated for pre-emptive row filtering, in ordering filter expression,
etc.
+ * This is an internal API and may go away at any time.
+ */
+ protected[spark] def expectedCost: Int = _expectedCost
Review Comment:
I think this is very hard to pick an integer value as the cost. Shall we
just add a bool flag `isExpensive`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
