pan3793 commented on code in PR #52742:
URL: https://github.com/apache/spark/pull/52742#discussion_r2493187636
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectStatement.scala:
##########
@@ -26,6 +26,8 @@ class SparkConnectStatement(conn: SparkConnectConnection)
extends Statement {
private var operationId: String = _
private var resultSet: SparkConnectResultSet = _
+ private var limitRow: Int = 0
Review Comment:
I think `@volatile` is not necessary. In practice, users may cache the
`Connection` in a pool and reuse it in different threads, but `Statement` is
not likely to be used in different threads, while `close` or `cancel` might be
called by a different thread.
Renamed `limitRow` to `maxRows`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
