hvanhovell commented on code in PR #52895:
URL: https://github.com/apache/spark/pull/52895#discussion_r2494688380
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -436,6 +436,7 @@ object SparkConnectService extends Logging {
return
}
+ sessionManager.initializeBaseSession(sc)
Review Comment:
I think this is fine for now, at some point we should consider making the
initialisation logic of connect less singleton heavy so we can pass the
SparkContext as a constructor parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
