cloud-fan commented on code in PR #52922:
URL: https://github.com/apache/spark/pull/52922#discussion_r2500561513
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala:
##########
@@ -315,6 +315,9 @@ private[parquet] class ParquetRowConverter(
}
catalystType match {
+ case NullType
+ if
parquetType.getLogicalTypeAnnotation.isInstanceOf[UnknownLogicalTypeAnnotation]
=>
+ new ParquetPrimitiveConverter(updater)
Review Comment:
this is also a dummy one and should not be invoked?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala:
##########
@@ -315,6 +315,9 @@ private[parquet] class ParquetRowConverter(
}
catalystType match {
+ case NullType
+ if
parquetType.getLogicalTypeAnnotation.isInstanceOf[UnknownLogicalTypeAnnotation]
=>
+ new ParquetPrimitiveConverter(updater)
Review Comment:
this is also returning a dummy one that should not be invoked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
