peter-toth commented on code in PR #52835: URL: https://github.com/apache/spark/pull/52835#discussion_r2501976269
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PlanMerger.scala: ########## @@ -0,0 +1,303 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import scala.collection.mutable.ArrayBuffer + +import org.apache.spark.sql.catalyst.expressions.{Alias, Attribute, AttributeMap, Expression, NamedExpression} +import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateExpression +import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, Filter, Join, LogicalPlan, Project} + +/** + * Result of attempting to merge a plan via [[PlanMerger.merge]]. + * + * @param mergedPlan The resulting plan, either: + * - An existing cached plan (if identical match found) + * - A newly merged plan combining the input with a cached plan + * - The original input plan (if no merge was possible) + * @param mergedPlanIndex The index of this plan in the PlanMerger's cache. + * @param merged Whether the plan was merged with an existing cached plan (true) or + * is a new entry (false). + * @param outputMap Maps attributes from the input plan to corresponding attributes in + * `mergedPlan`. Used to rewrite expressions referencing the original plan + * to reference the merged plan instead. + */ +case class MergeResult( + mergedPlan: LogicalPlan, Review Comment: Good idea! Let me change this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
