Ngone51 commented on code in PR #52792:
URL: https://github.com/apache/spark/pull/52792#discussion_r2501992800
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -380,7 +380,17 @@ private[spark] class Executor(
tr.kill(killMark._1, killMark._2)
killMarks.remove(taskId)
}
- threadPool.execute(tr)
+ try {
+ threadPool.execute(tr)
+ } catch {
+ case e: Throwable =>
Review Comment:
In the case of the uncontrolled `OutOfMemoryError`, I don't think we can
guarantee the status update always be sent successfully. I actually would
prefer shutdown the executor itself with an explicitly error code, e.g.,
`SparkExitCode.OOM` in the case of `OutOfMemoryError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
