pan3793 commented on code in PR #52947:
URL: https://github.com/apache/spark/pull/52947#discussion_r2507054581
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/util/JdbcTypeUtils.scala:
##########
@@ -48,12 +50,14 @@ private[jdbc] object JdbcTypeUtils {
case FloatType => classOf[JFloat].getName
case DoubleType => classOf[JDouble].getName
case StringType => classOf[String].getName
+ case DecimalType.Fixed(_, _) => classOf[JBigDecimal].getName
case other =>
throw new SQLFeatureNotSupportedException(s"DataType $other is not
supported yet.")
}
def isSigned(field: StructField): Boolean = field.dataType match {
- case ByteType | ShortType | IntegerType | LongType | FloatType |
DoubleType => true
+ case ByteType | ShortType | IntegerType | LongType | FloatType | DoubleType
+ | DecimalType.Fixed(_, _) => true
Review Comment:
nit:
```suggestion
case ByteType | ShortType | IntegerType | LongType | FloatType |
DoubleType |
_: DecimalType => true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
