szehon-ho commented on code in PR #52866:
URL: https://github.com/apache/spark/pull/52866#discussion_r2512496302
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1670,7 +1670,14 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
case u: UpdateTable => resolveReferencesInUpdate(u)
case m @ MergeIntoTable(targetTable, sourceTable, _, _, _, _, _)
- if !m.resolved && targetTable.resolved && sourceTable.resolved &&
!m.needSchemaEvolution =>
+ if !m.resolved && targetTable.resolved && sourceTable.resolved =>
+
+ // Do not throw exception for schema evolution case if it has not had
a chance to run.
+ // This allows unresolved assignment keys a chance to be resolved by a
second pass
+ // by newly column/nested fields added by schema evolution.
+ // If schema evolution has already had a chance to run, this will be
the final pass
+ val throws = !m.schemaEvolutionEnabled ||
Review Comment:
ok, but i have to keep it to keep behavior for non-schema changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
