garlandz-db commented on code in PR #52696:
URL: https://github.com/apache/spark/pull/52696#discussion_r2513202409
##########
common/utils/src/main/java/org/apache/spark/SparkThrowable.java:
##########
@@ -51,6 +51,7 @@ public interface SparkThrowable {
// Portable error identifier across SQL engines
// If null, error class or SQLSTATE is not set
+ // Deprecated: Override this method to provide explicit SQL state instead of
relying on error class reader
Review Comment:
new classes that inherit this class should override this method so that the
sql state property is used instead. Otherwise it will use error class reader
which reintroduces the problem we had previously. this comment is not good
enforcement admittedly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
