IrenaPan commented on code in PR #52996:
URL: https://github.com/apache/spark/pull/52996#discussion_r2513536661
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/KeyGroupedPartitioningSuite.scala:
##########
@@ -299,13 +299,13 @@ class KeyGroupedPartitioningSuite extends
DistributionAndOrderingSuiteBase {
Row("bbb", 20, 250.0), Row("bbb", 20, 350.0), Row("ccc", 30, 400.50)))
}
- private def collectAllShuffles(plan: SparkPlan): Seq[ShuffleExchangeExec] = {
+ protected def collectAllShuffles(plan: SparkPlan): Seq[ShuffleExchangeLike]
= {
collect(plan) {
case s: ShuffleExchangeExec => s
}
}
- private def collectShuffles(plan: SparkPlan): Seq[ShuffleExchangeExec] = {
+ protected def collectShuffles(plan: SparkPlan): Seq[ShuffleExchangeLike] = {
Review Comment:
For Apache gluten, we will override it when running this suite:
https://github.com/apache/incubator-gluten/blob/main/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/connector/GlutenKeyGroupedPartitioningSuite.scala
override def collectAllShuffles(plan: SparkPlan): Seq[ShuffleExchangeLike]
= {
collect(plan) { case s: ColumnarShuffleExchangeExec => s }
}
override def collectShuffles(plan: SparkPlan): Seq[ShuffleExchangeLike] = {
// here we skip collecting shuffle operators that are not associated
with SMJ
collect(plan) { case s: SortMergeJoinExecTransformer => s }.flatMap(
smj => collect(smj) { case s: ColumnarShuffleExchangeExec => s })
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
