harshmotw-db opened a new pull request, #53005:
URL: https://github.com/apache/spark/pull/53005
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR makes changes to the parquet writer to make it annotate variant
columns with the parquet variant logical type annotation.
### Why are the changes needed?
The Parquet spec has formally adopted the Variant logical type, and
therefore, Variant columns must be properly annotated in Spark 4.1.0 which
depends on Parquet-java 1.16.0 which contains the variant logical type
annotation.
This change is hidden behind a flag that is disabled by default until read
support can be properly implemented.
### Does this PR introduce _any_ user-facing change?
Yes, Parquet files written by Spark 4.1.0 with the flag enabled (which it
eventually will be by default) could contain the variant logical type
annotation which readers without support for the type will not be able to read
### How was this patch tested?
Unit test to check if nested as well as top-level variants are properly
annotated, and the data is being written correctly.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
