pan3793 commented on PR #53010: URL: https://github.com/apache/spark/pull/53010#issuecomment-3520272255
@vinodkc, thank you for implementing this feature. and thanks @dongjoon-hyun for quickly reviewing and merging. this PR basically looks good to me, but may need to have a few more checks: - does it work properly with `spark.sql.datetime.java8API.enabled` enabled/disabled? IIRC, STS forcibly enables it, but the Connect Client may have a different situation - does it work properly with days after `9999-12-31`? e.g. `10000-01-01` BTW, would you like to add TIMESTAMP/TIMESTAMP_NTZ support? Since we want to include a few more features in 4.1 (feature freeze is planned in Nov. 15), we can prioritize the feature implementation and defer some closer reviewing and bug fixing to the 4.1 QA period. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
