gaogaotiantian commented on code in PR #53008:
URL: https://github.com/apache/spark/pull/53008#discussion_r2517228295
##########
.github/workflows/build_and_test.yml:
##########
@@ -53,6 +53,9 @@ on:
codecov_token:
description: The upload token of codecov.
required: false
+concurrency:
+ group: build-test-${{ github.workflow }}-${{ github.repository ==
'apache/spark' && github.run_id || github.ref }}
+ cancel-in-progress: true
Review Comment:
That's the discussion we had above. So we don't want the master branch to
have sequential workflows. If we do `cancel-in-progress = false` on master
branch(or official spark repo), it will block the new commit until the old one
finishes. The current PR preserves the current behavior where all the commits
in master branch do workflows simultaneously.
##########
.github/workflows/build_and_test.yml:
##########
@@ -53,6 +53,9 @@ on:
codecov_token:
description: The upload token of codecov.
required: false
+concurrency:
+ group: build-test-${{ github.workflow }}-${{ github.repository ==
'apache/spark' && github.run_id || github.ref }}
+ cancel-in-progress: true
Review Comment:
That's the discussion we had above. So we don't want the master branch to
have sequential workflows. If we do `cancel-in-progress = false` on master
branch(or official spark repo), it will block the new commit workflow until the
old one finishes. The current PR preserves the current behavior where all the
commits in master branch do workflows simultaneously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
