xi-db commented on code in PR #53003:
URL: https://github.com/apache/spark/pull/53003#discussion_r2518662122
##########
sql/connect/client/jvm/pom.xml:
##########
@@ -184,6 +189,7 @@
<include>io.perfmark:*</include>
<include>org.apache.arrow:*</include>
<include>org.codehaus.mojo:*</include>
+ <include>com.github.luben:zstd-jni</include>
Review Comment:
Thanks for the comment. For this zstd-jni, it is tricky to shade because it
has native libraries. If we shade it, it will fail with error
`java.lang.UnsatisfiedLinkError: 'int
org.sparkproject.connect.com.github.luben.zstd.Zstd.defaultCompressionLevel()'`,
because the native library was compiled with the original package name. I'm
keeping it not shaded for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
