cloud-fan commented on code in PR #53006:
URL: https://github.com/apache/spark/pull/53006#discussion_r2522222967


##########
dev/create-release/release-build.sh:
##########
@@ -835,11 +835,12 @@ if [[ "$1" == "docs" ]]; then
   PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" bundle exec jekyll build
 
   # Generate llms.txt for LLM consumption
+  # Note this doc is currently versionless and need to be placed at the 
documentation root.
   echo "Generating llms.txt..."
   python "$SELF/generate-llms-txt.py" \
     --docs-path . \
-    --output "$SELF/_site/llms.txt" \
-    --version "$SPARK_VERSION"
+    --output "$SELF/llms.txt" \

Review Comment:
   Does mean we should only do it when releasing the latest major/feature 
version? We should'n overwrite it with a legacy version when releasing 4.0.1 
for example.



##########
dev/create-release/release-build.sh:
##########
@@ -835,11 +835,12 @@ if [[ "$1" == "docs" ]]; then
   PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" bundle exec jekyll build
 
   # Generate llms.txt for LLM consumption
+  # Note this doc is currently versionless and need to be placed at the 
documentation root.
   echo "Generating llms.txt..."
   python "$SELF/generate-llms-txt.py" \
     --docs-path . \
-    --output "$SELF/_site/llms.txt" \
-    --version "$SPARK_VERSION"
+    --output "$SELF/llms.txt" \

Review Comment:
   Does mean we should only do it when releasing the latest major/feature 
version? We should'n overwrite it with an old version when releasing 4.0.1 for 
example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to