andylam-db commented on code in PR #53044: URL: https://github.com/apache/spark/pull/53044#discussion_r2524806572
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala: ########## @@ -48,14 +48,14 @@ class AttributeMap[A](val baseMap: Map[ExprId, (Attribute, A)]) override def contains(k: Attribute): Boolean = get(k).isDefined override def + [B1 >: A](kv: (Attribute, B1)): AttributeMap[B1] = - AttributeMap(baseMap.values.toMap + kv) + new AttributeMap(baseMap + (kv._1.exprId -> kv)) override def updated[B1 >: A](key: Attribute, value: B1): Map[Attribute, B1] = - baseMap.values.toMap + (key -> value) + this + (key -> value) override def iterator: Iterator[(Attribute, A)] = baseMap.valuesIterator - override def removed(key: Attribute): Map[Attribute, A] = baseMap.values.toMap - key + override def removed(key: Attribute): Map[Attribute, A] = new AttributeMap(baseMap - key.exprId) Review Comment: To be clear for other reviewers: Converting the internal baseMap to a regular `Map[Attribute, A]` that hashes on Attribute objects directly is the problem here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
