zhengruifeng commented on code in PR #53043:
URL: https://github.com/apache/spark/pull/53043#discussion_r2525678793
##########
python/pyspark/sql/pandas/serializers.py:
##########
@@ -1265,8 +1228,9 @@ def __init__(
safecheck,
assign_cols_by_name,
int_to_decimal_coercion_enabled,
+ use_iterator=False,
Review Comment:
please keep in line with `GroupPandasUDFSerializer`, we should not add such
`use_iterator` argument, this serializer always return iterator,
and then adjust the function wrappers, you can refer to
`wrap_grouped_map_arrow_udf` and `wrap_grouped_map_arrow_iter_udf`
##########
python/pyspark/sql/pandas/serializers.py:
##########
@@ -1265,8 +1228,9 @@ def __init__(
safecheck,
assign_cols_by_name,
int_to_decimal_coercion_enabled,
+ use_iterator=False,
Review Comment:
please keep in line with `GroupArrowUDFSerializer`, we should not add such
`use_iterator` argument, this serializer always return iterator,
and then adjust the function wrappers, you can refer to
`wrap_grouped_map_arrow_udf` and `wrap_grouped_map_arrow_iter_udf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
