pan3793 commented on code in PR #53018:
URL: https://github.com/apache/spark/pull/53018#discussion_r2521724784
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/util/JdbcTypeUtils.scala:
##########
@@ -37,6 +37,7 @@ private[jdbc] object JdbcTypeUtils {
case StringType => Types.VARCHAR
case _: DecimalType => Types.DECIMAL
case DateType => Types.DATE
+ case BinaryType => Types.BINARY
Review Comment:
`VARBINARY` might be more suitable here.
some references:
- Databricks JDBC driver uses BINARY for BinaryType
- PostgreSQL JDBC driver uses BINARY for bytea
- Trino JDBC driver uses VARBINARY for varbinary
- MariaDB JDBC driver uses VARBINARY/LONGVARBINARY for
TINYBLOB/MEDIUMBLOB/LONGBLOB/BLOB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
