dongjoon-hyun commented on code in PR #53024:
URL: https://github.com/apache/spark/pull/53024#discussion_r2528686102
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/pipelines/PythonPipelineSuite.scala:
##########
@@ -902,4 +1027,82 @@ class PythonPipelineSuite
s"Table should have no transforms, but got: ${stTransforms.mkString(",
")}")
}
}
+
+ // List of unsupported SQL commands that should result in a failure.
+ private val unsupportedSqlCommandList: Seq[String] = Seq(
+ "SET CATALOG some_catalog",
+ "USE SCHEMA some_schema",
+ "SET `test_conf` = `true`",
+ "CREATE TABLE some_table (id INT)",
+ "CREATE VIEW some_view AS SELECT * FROM some_table",
+ "INSERT INTO some_table VALUES (1)",
+ "ALTER TABLE some_table RENAME TO some_new_table",
+ "CREATE NAMESPACE some_namespace",
+ "DROP VIEW some_view",
+ "CREATE MATERIALIZED VIEW some_view AS SELECT * FROM some_table",
+ "CREATE STREAMING TABLE some_table AS SELECT * FROM some_table")
+
+ gridTest("Unsupported SQL command outside query function should result in a
failure")(
+ unsupportedSqlCommandList) { unsupportedSqlCommand =>
+ val ex = intercept[RuntimeException] {
+ buildGraph(s"""
+ |spark.sql("$unsupportedSqlCommand")
+ |
+ |@dp.materialized_view()
+ |def mv():
+ | return spark.range(5)
+ |""".stripMargin)
+ }
+ assert(ex.getMessage.contains("UNSUPPORTED_PIPELINE_SPARK_SQL_COMMAND"))
+ }
+
+ gridTest("Unsupported SQL command inside query function should result in a
failure")(
+ unsupportedSqlCommandList) { unsupportedSqlCommand =>
+ val ex = intercept[RuntimeException] {
+ buildGraph(s"""
+ |@dp.materialized_view()
Review Comment:
ditto.
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/pipelines/PythonPipelineSuite.scala:
##########
@@ -902,4 +1027,82 @@ class PythonPipelineSuite
s"Table should have no transforms, but got: ${stTransforms.mkString(",
")}")
}
}
+
+ // List of unsupported SQL commands that should result in a failure.
+ private val unsupportedSqlCommandList: Seq[String] = Seq(
+ "SET CATALOG some_catalog",
+ "USE SCHEMA some_schema",
+ "SET `test_conf` = `true`",
+ "CREATE TABLE some_table (id INT)",
+ "CREATE VIEW some_view AS SELECT * FROM some_table",
+ "INSERT INTO some_table VALUES (1)",
+ "ALTER TABLE some_table RENAME TO some_new_table",
+ "CREATE NAMESPACE some_namespace",
+ "DROP VIEW some_view",
+ "CREATE MATERIALIZED VIEW some_view AS SELECT * FROM some_table",
+ "CREATE STREAMING TABLE some_table AS SELECT * FROM some_table")
+
+ gridTest("Unsupported SQL command outside query function should result in a
failure")(
+ unsupportedSqlCommandList) { unsupportedSqlCommand =>
+ val ex = intercept[RuntimeException] {
+ buildGraph(s"""
+ |spark.sql("$unsupportedSqlCommand")
+ |
+ |@dp.materialized_view()
+ |def mv():
+ | return spark.range(5)
+ |""".stripMargin)
+ }
+ assert(ex.getMessage.contains("UNSUPPORTED_PIPELINE_SPARK_SQL_COMMAND"))
+ }
+
+ gridTest("Unsupported SQL command inside query function should result in a
failure")(
+ unsupportedSqlCommandList) { unsupportedSqlCommand =>
+ val ex = intercept[RuntimeException] {
+ buildGraph(s"""
+ |@dp.materialized_view()
+ |def mv():
+ | spark.sql("$unsupportedSqlCommand")
+ | return spark.range(5)
+ |""".stripMargin)
+ }
+ assert(ex.getMessage.contains("UNSUPPORTED_PIPELINE_SPARK_SQL_COMMAND"))
+ }
+
+ // List of supported SQL commands that should work.
+ val supportedSqlCommandList: Seq[String] = Seq(
+ "DESCRIBE TABLE spark_catalog.default.src",
+ "SHOW TABLES",
+ "SHOW TBLPROPERTIES spark_catalog.default.src",
+ "SHOW NAMESPACES",
+ "SHOW COLUMNS FROM spark_catalog.default.src",
+ "SHOW FUNCTIONS",
+ "SHOW VIEWS",
+ "SHOW CATALOGS",
+ "SHOW CREATE TABLE spark_catalog.default.src",
+ "SELECT * FROM RANGE(5)",
+ "SELECT * FROM spark_catalog.default.src")
+
+ gridTest("Supported SQL command outside query function should
work")(supportedSqlCommandList) {
+ supportedSqlCommand =>
+ sql("CREATE TABLE spark_catalog.default.src AS SELECT * FROM RANGE(5)")
+ buildGraph(s"""
+ |spark.sql("$supportedSqlCommand")
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
