gaogaotiantian commented on code in PR #53045:
URL: https://github.com/apache/spark/pull/53045#discussion_r2529180252
##########
python/pyspark/sql/pandas/conversion.py:
##########
@@ -53,6 +54,83 @@
from pyspark.sql import DataFrame
+def _convert_arrow_table_to_pandas(
+ *,
Review Comment:
nit: I think it's okay to have the table before `*`. Also I'm don't feel
it's necessary to have the `*` here just because it does not seem like a
pattern elsewhere. I think it's a good habit to call with keyword arguments,
but enforcing it normally is only required on user facing interfaces where they
could easily make a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]