Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6723#discussion_r32024488
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -139,10 +139,8 @@ abstract class Expression extends TreeNode[Expression]
{
* Checks the input data types, returns `TypeCheckResult.success` if
it's valid,
* or returns a `TypeCheckResult` with an error message if invalid.
* Note: it's not valid to call this method until `childrenResolved ==
true`
- * TODO: we should remove the default implementation and implement it
for all
- * expressions with proper error message.
*/
- def checkInputDataTypes(): TypeCheckResult =
TypeCheckResult.TypeCheckSuccess
+ def checkInputDataTypes(): TypeCheckResult
--- End diff --
Do we really want this? There are a lot of expressions that don't need type
check...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
