AngersZhuuuu commented on code in PR #52792:
URL: https://github.com/apache/spark/pull/52792#discussion_r2532890817
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -381,7 +381,28 @@ private[spark] class Executor(
tr.kill(killMark._1, killMark._2)
killMarks.remove(taskId)
}
- threadPool.execute(tr)
+ try {
+ threadPool.execute(tr)
+ } catch {
+ case t: Throwable =>
+ try {
+ logError(log"Executor launch task ${MDC(TASK_NAME,
taskDescription.name)} failed," +
+ log" reason: ${MDC(REASON, t.getMessage)}")
+ context.statusUpdate(
Review Comment:
@Ngone51 means that if the RPC requests also fail due to OutOfMemoryError
(OOM), exiting the executor can trigger corresponding task rerun to avoid
getting stuck.
In my PR's scenario, this might be necessary in a special case. However, if
the task is already running, I think it's unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
