vrozov commented on PR #53074: URL: https://github.com/apache/spark/pull/53074#issuecomment-3543327492
> @vrozov How about just using a concurrent collection like `LinkedBlockingQueue` for `buffer`? @sarutak Thank you for suggestions. The PR uses existing `lock` that will be still required even if `buffer` is changed from `ArrayBuffer` to `LinkedBlockingQueue` to synchronize between `ProcessOutputCapturer` for `stdout` and `stderr`. Additionally, queue usage pattern (take one element at a time from head or tail) does not apply well here as it outputs the entire `buffer` (collection). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
