szehon-ho commented on code in PR #53098:
URL: https://github.com/apache/spark/pull/53098#discussion_r2535535415
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/exchange/EnsureRequirementsSuite.scala:
##########
@@ -45,6 +46,17 @@ class EnsureRequirementsSuite extends SharedSparkSession {
private val EnsureRequirements = new EnsureRequirements()
+ /** Helper to add dummy BatchScanExec child to a dummy plan (to ensure SPJ
can kick in). */
Review Comment:
actually why not have another case class altogether (that inherit from
DummySparkPlan) and use that in the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
