chirag-s-db commented on code in PR #53097:
URL: https://github.com/apache/spark/pull/53097#discussion_r2535766018
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/InternalRowComparableWrapper.scala:
##########
@@ -112,3 +112,65 @@ object InternalRowComparableWrapper {
result.toSeq
}
}
+
+/**
+ * Effectively the same as [[InternalRowComparableWrapper]], but using a
precomputed `ordering`
+ * and `structType` to avoid the cache lookup for each row.
+ */
+class BoundInternalRowComparableWrapper(
Review Comment:
Good suggestion - I actually removed the new
`BoundInternalRowComparableWrapper` and used this pattern on the original
`InternalRowComparableWrapper` (since it would work equally well there as
well). I kept the original constructor for binary compatibility, but marked it
deprecated for the reasons explained in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
