holdenk commented on code in PR #53096:
URL: https://github.com/apache/spark/pull/53096#discussion_r2536027113
##########
python/pyspark/pandas/tests/computation/test_any_all.py:
##########
@@ -135,6 +135,11 @@ def test_any(self):
self.assert_eq(psdf.any(bool_only=True), pdf.any(bool_only=True))
self.assert_eq(psdf.any(bool_only=False), pdf.any(bool_only=False))
+ # Test axis=1
Review Comment:
Maybe silly but do we also want to test the call with names one?
##########
python/pyspark/pandas/frame.py:
##########
@@ -11195,29 +11195,55 @@ def any(
>>> df[[]].any()
Series([], dtype: bool)
"""
- axis = validate_axis(axis)
Review Comment:
Do we still want to call validate_axis to convert it to a numeric ref
(otherwise I don't think we'd handle the string inputs properly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
