ganeshashree commented on code in PR #53091:
URL: https://github.com/apache/spark/pull/53091#discussion_r2533807020
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2AlterTableCommands.scala:
##########
@@ -48,7 +48,11 @@ trait AlterTableCommand extends UnaryCommand {
*/
case class CommentOnTable(table: LogicalPlan, comment: String) extends
AlterTableCommand {
override def changes: Seq[TableChange] = {
- Seq(TableChange.setProperty(TableCatalog.PROP_COMMENT, comment))
+ if (comment == null || comment.isEmpty) {
Review Comment:
I referred to [this Oracle
document](https://docs.oracle.com/en/database/oracle/oracle-database/21/sqlrf/COMMENT.html),
which states to set the comment as empty to remove it. I thought setting it to
empty was equivalent to removing it. However, if setting it to empty is
necessary as a placeholder, we can still permit it.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2AlterTableCommands.scala:
##########
@@ -48,7 +48,11 @@ trait AlterTableCommand extends UnaryCommand {
*/
case class CommentOnTable(table: LogicalPlan, comment: String) extends
AlterTableCommand {
override def changes: Seq[TableChange] = {
- Seq(TableChange.setProperty(TableCatalog.PROP_COMMENT, comment))
+ if (comment == null || comment.isEmpty) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
