lifulong commented on code in PR #52701:
URL: https://github.com/apache/spark/pull/52701#discussion_r2536848565
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -1182,8 +1182,8 @@ class DataFrameAggregateSuite extends QueryTest
approx_percentile(col("earnings"), lit(0.3), lit(1)),
approx_percentile(col("earnings"), array(lit(0.3), lit(0.6)), lit(1))
),
- Row("Java", 20000.0, Seq(20000.0, 30000.0), 20000.0, Seq(20000.0,
20000.0)) ::
- Row("dotNET", 5000.0, Seq(5000.0, 10000.0), 5000.0, Seq(5000.0,
5000.0)) :: Nil
+ Row("Java", 20000.0, Seq(20000.0, 30000.0), 20000.0, Seq(20000.0,
30000.0)) ::
Review Comment:
yes, new result also meets the accuracy requirements, and new result is more
accurate
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -1182,8 +1182,8 @@ class DataFrameAggregateSuite extends QueryTest
approx_percentile(col("earnings"), lit(0.3), lit(1)),
approx_percentile(col("earnings"), array(lit(0.3), lit(0.6)), lit(1))
),
- Row("Java", 20000.0, Seq(20000.0, 30000.0), 20000.0, Seq(20000.0,
20000.0)) ::
- Row("dotNET", 5000.0, Seq(5000.0, 10000.0), 5000.0, Seq(5000.0,
5000.0)) :: Nil
+ Row("Java", 20000.0, Seq(20000.0, 30000.0), 20000.0, Seq(20000.0,
30000.0)) ::
Review Comment:
yes, new result also meets the accuracy requirements, and new result is more
accurate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
