pan3793 commented on code in PR #52584:
URL: https://github.com/apache/spark/pull/52584#discussion_r2537051367
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/V1WriteHiveCommandSuite.scala:
##########
@@ -126,4 +127,37 @@ class V1WriteHiveCommandSuite
}
}
}
+
+ test("v1 write to hive table with sort by literal column preserve custom
order") {
+ withCovnertMetastore { _ =>
+ withPlannedWrite { enabled =>
Review Comment:
it's correct that the variable `enabled` is not referenced, but the wrapper
`withPlannedWrite` is indeed required, we should ensure to preserve the
user-provided sort w/ and w/o enabling planned write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
