sarutak commented on code in PR #53116:
URL: https://github.com/apache/spark/pull/53116#discussion_r2539186913
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -546,14 +546,15 @@ private boolean isKerberosAuthMode(String authType) {
return
authType.equalsIgnoreCase(HiveAuthFactory.AuthTypes.KERBEROS.toString());
}
- private static String getDoAsQueryParam(String queryString) {
+ private static String getDoAsQueryParam(HttpServletRequest request) {
+ String queryString = request.getQueryString();
if (LOG.isDebugEnabled()) {
LOG.debug("URL query string:" + queryString);
}
if (queryString == null) {
return null;
}
- Map<String, String[]> params =
jakarta.servlet.http.HttpUtils.parseQueryString( queryString );
Review Comment:
@dongjoon-hyun
You mean, merge this part first in another PR and then merge this PR right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
