gaogaotiantian commented on PR #53113: URL: https://github.com/apache/spark/pull/53113#issuecomment-3549082669
This is a very bad practice and I highly suggest that we don't do it. I don't believe UDT should be hashable. If I understand correctly, UDT can be mutable right? Mutable object should not be hashable. Also if two objects are equal, they must have the same hash - the current implementation does not guarantee that. Why is the `__eq__` implementation so strange? Why do we need this to be hashable? No every object should be hashable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
