harshmotw-db opened a new pull request, #53120:
URL: https://github.com/apache/spark/pull/53120

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the 
guideline first in
        'common/utils/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   
   [This PR](https://github.com/apache/spark/pull/53005) introduced a fix where 
the Spark parquet writer would annotate variant columns with the parquet 
variant logical type. The PR had an ad-hoc fix on the reader side for 
validation. This PR formally allows Spark to read parquet files with the 
Variant logical type.
   
   The PR also introduces an unrelated fix in ParquetRowConverter to allow 
Spark to read variant columns regardless of which order the value and metadata 
fields are stored in.
   
   ### Why are the changes needed?
   
   The variant logical type annotation has formally been adopted as part of the 
parquet spec in is part of the parquet-java 1.16.0 library. Therefore, Spark 
should be able to read files containing data annotated as such.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, it allows users to read parquet files with the variant logical type 
annotation.
   
   ### How was this patch tested?
   
   Existing test from [this PR](https://github.com/apache/spark/pull/53005) 
where we wrote data of the variant logical type and tested read using an ad-hoc 
solution.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to