sryza commented on code in PR #53089:
URL: https://github.com/apache/spark/pull/53089#discussion_r2540456686
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/SystemMetadata.scala:
##########
@@ -62,6 +65,13 @@ case class FlowSystemMetadata(
})
}
+ /**
+ * Converts a TableIdentifier to a path string by joining its name parts
with the path separator.
+ */
+ private def tableIdentifierToPathString(tableIdentifier: TableIdentifier):
String = {
Review Comment:
In general, `SystemMetadataSuite` reimplements the path construction logic
rather than relying on methods in `SystemMetadata`, to ensure that we'll catch
any changes to the behavior if those methods change.
So my inclination is to avoid reusing this helper there for that reason, but
don't mind changing it if you feel strongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
