sarutak commented on code in PR #53116:
URL: https://github.com/apache/spark/pull/53116#discussion_r2540704858
##########
core/src/test/scala/org/apache/spark/ui/UISuite.scala:
##########
@@ -234,7 +234,7 @@ class UISuite extends SparkFunSuite {
val targetUri = URI.create(s"http://$localhost:4040";)
when(clientRequest.getScheme()).thenReturn("http")
when(clientRequest.getHeader("host")).thenReturn(s"$localhost:8080")
- when(clientRequest.getPathInfo()).thenReturn("/proxy/worker-id/jobs")
+ when(clientRequest.getPathInfo()).thenReturn("/worker-id/jobs")
Review Comment:
Good question. This change is relevant to [this
part](https://github.com/apache/spark/pull/53116/files#diff-bb2ed90c22fe4b314488f3ffbd32e9998a9fd2dae994ea575b264d81f060cba7R433).
`/proxy` is a [context
root](https://github.com/apache/spark/blob/5fb072e4f25f471e69e2b81ee0155cc24a20725a/core/src/main/scala/org/apache/spark/ui/JettyUtils.scala#L235)
so the returned value from `HttpServletRequest#getPathInfo` should not
contains `/proxy`. In old versions of Jetty, the returned value can strangely
contain a context root.
As of Jetty 12, Jetty specific `Core API` and the standard Servlet API are
decoupled and `getPathInfo` doesn't return a path with a context root (`/proxy`
in this case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
